-
Notifications
You must be signed in to change notification settings - Fork 82
[v5] Fixed invalid code sample includes #2967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
adriendupuis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few highlight offsets and unneeded new lines.
Few $output->writeln are not really necessary and narrow the example to CLI, but some are really important to fastly illustrate properties and/or looping; could be debated.
Co-authored-by: Adrien Dupuis <[email protected]>
|
@adriendupuis suggestions applied in 933f2e3 Then manual changes in 010022f and 6ce757c Thank you for your review! |
code_samples/ change report
|
This PR fixes the wrong file includes in different files of the doc (after I've broken them when upgrading the code to v5).