Add test for file variations #31
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a test that mutates the image files we already have and checks that decoders do not panic for them. Current mutations include:
imagetests for too.This would have found a panic in OBT that was fixed by #28.
Unfortunately, this test is currently a lot slower than it has to be because
imageonly supports using plugins when reading files. This forces the test to write the modified files to disk for every mutation that we want to test. Writing to disk makes the test a lot slower than it has to be, but it's not too bad. It only takes 2 sec on my machine.I made image-rs/image#2662 to address this API oversight. But even if a solution gets added, we probably won't be able to use the solution right away due to version compatibility.