tga: decode 5-bit-per-primary images #2609
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very loosely based on another PR to implement decoding of 5-bit-per-primary TGA images, #2303. That PR (also licensed
MIT OR Apache-2.0) has not been updated in a bit more than a year, in which time there have been refactorings and other changes to the TGA decoder which would require additional work to resolve merge conflicts for. As a result, I expect it is unlikely that it will be updated this year, and am making this PR to try to have the feature implemented more quickly.Notes:
ExtendedColorType::Rgb5enum entry to indicate the "type" of image data being provided. A precise description of the pixel format used by uncompressed true-color 5 bit-per-primary TGA images is DRM_FORMAT_XRGB1555, but I don't think going into such precision is appropriate for how ExtendedColorType is used.imagecrate, specifically asMIT OR Apache-2.0. You may also use them under CC0.Let me know if you'd like me to make any changes, split off the addition of ExtendedColor::Rgb5 into another commit, etc.