-
Notifications
You must be signed in to change notification settings - Fork 241
add terminal agent with openai-agents #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @CormickKneey, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the system's capabilities by integrating a new terminal agent training pipeline. The core purpose is to allow AI agents to learn and perform complex tasks directly within a terminal environment, leveraging the OpenAI Agents SDK. This is achieved through a new multi-container orchestration (MCP) server that provides isolated terminal environments, specialized tools for agent interaction, and a structured workflow for reinforcement learning. The changes also include necessary adjustments to ensure seamless compatibility with the underlying OpenAI Agents SDK, making the entire system more robust and functional for terminal-based AI development. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant new feature: a terminal agent with its environment and training workflow, built on the OpenAI Agents SDK. The implementation is comprehensive, including a dedicated server for managing terminal environments, dataset converters, and the agent logic itself. The compatibility fixes for the OpenAI SDK are also a good improvement. My review focuses on improving correctness, maintainability, and efficiency in a few areas. Key suggestions include fixing a potential crash due to unhandled None rewards, resolving duplicate logging, improving dataset processing efficiency, and making logging paths consistent.
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a comprehensive terminal agent training feature, including a new agent workflow, a dedicated MCP server for managing terminal environments, and data processing scripts for the Terminal-Bench dataset. It also includes compatibility fixes for the OpenAI Agents SDK. The implementation is extensive and well-documented. My review focuses on improving code maintainability, fixing some minor bugs in documentation and imports, and adhering to Python best practices. Key suggestions include refactoring a large server file, correcting import patterns, and improving logging practices.
aecf41f to
1e6c0f5
Compare
cba52ee to
53b11ed
Compare
Signed-off-by: CormickKneey <[email protected]>
53b11ed to
ad21378
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity within the last 14 days. Please add a comment or push new commits to keep it active. Thank you for your contribution! |
Description
This PR adds terminal agent training support and fixes compatibility issues with the OpenAI Agents SDK.
Main Changes:
New Terminal Agent Example: Implements a complete terminal task execution workflow using Terminal-Bench dataset
OpenAI Agents SDK Compatibility Fixes:
Related Issue
Fixes #(issue)
Type of Change
Checklist
Additional Context
Example Training Command:
Experiment results with Qwen3-4B-Thinking-2507 included in
assets/qwen3_4b_thinking_terminal.png.(No so good, but can be reference)