nvfortran as a CUDA compiler #492
Closed
+362
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed output array to intent(out) in phase example.
Owner
|
Sorry, not a fan of this either, since this duplicates the code, meaning that there are now two copies that need to be maintained. As I mentioned in #491, I was hoping for the two module kinds to share code, but via inheritance, not via While we're at it, there should be an automated test for this functionality. See |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I followed your suggestion to make a new class. The changes to use nvfortran are all in the file fortran.py which contains the class SourceModuleFortran. The two fortran examples are updated to use this.
I am sure there are other problems, let me know what you think, and especially if the whole idea seems unsuitable.