-
Notifications
You must be signed in to change notification settings - Fork 536
Support for Precognition in useForm()
#2684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pascalbaljet
wants to merge
48
commits into
master
Choose a base branch
from
precognition-useform
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates Precognition into
useForm(). We currently support this by installing thelaravel-precognition-react-inertiaorlaravel-precognition-vue-inertialibrary and using theuseForm()hook from those libraries. With this PR, that is no longer needed. We're bringing first-party support for Precognition.For a smooth upgrade, you may use the existing parameters by passing the method and URL before the initial data. In that case, you only need to swap the
useFormimport from the Precognition library to@inertiajs/{react,svelte,vue3}.If you're not using the Precognition library, you can enable Precognition on existing forms by simply chaining the
withPrecognition()method.When doing this, you no longer need to pass the method and URL to the
submit()method, but you may still pass visit options.There is now also full support for Wayfinder when using Precognition.
Other than instantiating the form instance, the API and behavior remain exactly the same.
And for the first time, we now also have support for Svelte!