Skip to content

Conversation

@harp-intel
Copy link
Contributor

@harp-intel harp-intel commented Dec 4, 2025

This pull request refactors the codebase to replace direct dependencies on the report package for table-related constants, types, and functions with the new table package. This change improves modularity and separation of concerns by centralizing all table-related logic in the table package. No functional behavior is changed, but many files are updated to use the new import and references.

This refactor should make it easier to maintain and extend table-related functionality in the future, as all such logic is now centralized in the table package.

@harp-intel harp-intel requested a review from Copilot December 4, 2025 23:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the codebase to extract table-related functionality from the report package into a new dedicated table package, improving modularity and separation of concerns. The refactoring moves table definitions, helper functions, type definitions, and table value processing logic while maintaining all existing functionality through updated imports and references.

Key changes:

  • Created new internal/table package with extracted table logic
  • Updated all consumers to import and use table package instead of report
  • Introduced renderer registration pattern for custom table rendering
  • Moved test files to align with new package structure

Reviewed changes

Copilot reviewed 47 out of 47 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
internal/table/*.go New table package files containing extracted logic from report package
internal/table/*_test.go Test files moved/created for table package
internal/report/*.go Updated to use table package and implement renderer registration
internal/common/common.go Updated imports and type references to use table package
cmd/*/ Updated command files to use table package for table name constants
go.mod Added module replace directive for new table package
internal/report/table_helpers*.go Deleted files as logic moved to table package
internal/report/*_defs.go Deleted definition files moved to table package

Signed-off-by: Harper, Jason M <[email protected]>
Signed-off-by: Harper, Jason M <[email protected]>
@harp-intel harp-intel marked this pull request as ready for review December 5, 2025 01:10
@harp-intel harp-intel marked this pull request as draft December 5, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants