fix: Try to connect to VM management IP without retrieving it from host #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue where the VM creation process would fail if the management IP address could not be retrieved from the host OS. The fix adds exception handling to catch HyperVException during IP retrieval and logs the error instead of crashing, allowing the VM connection attempt to proceed.
Key Changes:
- Added try-except block around
_wait_vm_mng_ips()call to catch and logHyperVException - Allows VM creation to continue even when management IP retrieval fails
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
KTokarze
changed the title
KTokarze
force-pushed
the
vm_mng_ip_fix
branch
from
676d48b to
478c3d4
Compare
Catch HyperVException when VM management IP address is not retrieved by host OS and try to connect to VM anyway. Fixes intel#8 Signed-off-by: Kacper Tokarzewski <[email protected]>
KTokarze
force-pushed
the
vm_mng_ip_fix
branch
from
478c3d4 to
5f4c4b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch HyperVException when VM management IP address is not retrieved by host OS and try to connect to VM anyway.
Fixes #8