Fix logic for invalidating a REST session #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@gjsjohnmurray @isc-rsingh Do you think requests that failed to send should prompt the user with an auth challenge? Or should we treat that like a 500 error? |
Collaborator
|
@isc-bsaviano what would have happened before your #294 change? If the request fails to send because of connectivity I'm not sure it makes sense to prompt the user for credentials. |
Collaborator
Author
|
It wouldn't have prompted for credentials. I am ok with reverting back to that behavior if you agree. |
gjsjohnmurray
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes intersystems/language-server#384