dropdown: enable mutliple selection by default #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jrcastro2
commented
Dec 4, 2025
jrcastro2
commented
- Adds support and default implementation for multiple selection
- closes 1 - Enhance e-mail notifications CERNDocumentServer/cds-rdm#628
* Adds support and default implementation for multiple selection * closes CERNDocumentServer/cds-rdm#628
jrcastro2
force-pushed
the
improve-dropdown
branch
from
7d88453 to
12760f0
Compare
kpsherva
reviewed
Dec 12, 2025
| }; | ||
|
|
||
| componentDidUpdate(prevProps) { | ||
| if (prevProps.options !== this.props.options) { |
Contributor
There was a problem hiding this comment.
please fix these eslint warnings
kpsherva
reviewed
Dec 12, 2025
| import { FeedbackLabel } from "../forms/FeedbackLabel"; | ||
|
|
||
| export class SelectField extends Component { | ||
| constructor(props) { |
Contributor
There was a problem hiding this comment.
not sure I understand why we need to add state management for this component, could you explain me?
kpsherva
reviewed
Dec 12, 2025
| } = cmpProps; | ||
| const _defaultValue = multiple ? [] : ""; | ||
| const value = getIn(values, fieldPath, defaultValue || _defaultValue); | ||
| console.log("defaultValue:", defaultValue); |
Contributor
There was a problem hiding this comment.
Suggested change
| console.log("defaultValue:", defaultValue); |
kpsherva
reviewed
Dec 12, 2025
Comment on lines
+115
to
+117
| console.log("SelectField fieldPath:", fieldPath); | ||
| console.log("SelectField value:", value); | ||
| console.log("SelectField options:", dropdownOptions); |
Contributor
There was a problem hiding this comment.
Suggested change
| console.log("SelectField fieldPath:", fieldPath); | |
| console.log("SelectField value:", value); | |
| console.log("SelectField options:", dropdownOptions); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.