This repository was archived by the owner on Jun 30, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 41
Converge fork with main repo #34
Open
mlopes
wants to merge
19
commits into
inviqa:develop
Choose a base branch
from
mlopes:unstable/MSGD
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
3ee490c
Merge branch 'feature/xcache' into unstable/MSGD
mlopes c5abf0f
Merge branch 'feature/add-mbstring' into unstable/MSGD
mlopes 3c71a88
Merge branch 'feature/xcache' into unstable/MSGD
mlopes 581d902
Merge branch 'feature/fix-default-value-for-cacher-option' into unsta…
mlopes 105a866
Merge branch 'feature/fix-zend_extension-bug-caused-by-ius-update' in…
mlopes 06887cd
Merge remote-tracking branch 'upstream/master' into unstable/MSGD
mlopes 369595f
Make memory_limit configurable
mlopes e1714dd
Merge branch 'feature/make-predis-compatible-with-redhat-family' into…
mlopes 788013e
Merge branch 'feature/fix-package-names-for-redhat-family' into unsta…
mlopes d476427
Replace wrong php_pear provider with chef_php_extra_pear provider
mlopes 1df5597
Update version of php codesnifer
mlopes a34cd95
Lock apt dependency version
mlopes 9140149
Downgrade dependency on php cookbook to v1.1.0
mlopes bf4895e
Fix imagick recipe for redhat based distros
mlopes e67aa93
Merge remote-tracking branch 'inviqa/master' into unstable/MSGD
debo b457a95
Merge pull request #1 from MarcoDeBortoli/unstable/MSGD
mlopes 927e110
Added two additional platforms to support as part of the redhat family
debo 02c0c85
Bump version to 0.5.0
debo 9e29bd9
Merge pull request #2 from MarcoDeBortoli/unstable/MSGD
mlopes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure we need to revert to an older version of the opscode php cookbook?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's part of the Missguided customisation unfortunately. We could make it cleaner and use our project based Cheffile to ensure the expected project dependency. Would that be better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would that work as a solutions? This version of the chef-php-extra will depend on the php 1.1.8 cookbook, I don't think it will be possible to lock the cookbook to 1.1.0 with the Cheffile if one of the cookbooks requires a more recent version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We did the same yesterday with the dmg cookbooks while creating my VM if you remember
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case the cookbook that required the dependency was not specifying the version of the dependency. Because of that, librarian-chef update was downloading the latest version, but we could still lock it to any other version.