-
Notifications
You must be signed in to change notification settings - Fork 4
feat(transaction-builder): Add support for extensible async signer #445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 19886963795Details
💛 - Coveralls |
thibault-martinez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this PR mean for the FFIs?
No change to that API |
I know but my point was that maybe it should? Bindings won't have traits so the existing methods still take a |
| /// This trait can be implemented downstream to enable signing when using the | ||
| /// [`TransactionBuilder`](crate::TransactionBuilder) | ||
| /// [`execute`](crate::TransactionBuilder::execute) function. | ||
| pub trait Signer { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have thought about our discussion a bit more and concluded that I would be fine with this only handling transaction signatures if we rename it to TransactionSigner. This ends up in the global scope of the bindings and having something called Signer than handles only one of the signature possibilities is just not ok. I can do it if you want.
Description
Adds a new trait to the transaction builder crate,
Signer, which defines one simple methodsignto sign a transaction asynchronously. This is implemented for any type that implementsIotaSignerand thus supports basic signing as well as passing the transaction to other services which hold the appropriate secrets.Closes #436