Rwiltz/controller play reset #4035
Draft
+1,044
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Switch delta time to use wall clock time instead of physics step time. Update config values to compensate. * Add support for decoupling anchor rotation as a toggle when pressing right controller A button. * Fix reset not working Refactor motion controller specific code into OpenXRDeviceMotionController. If we are doing only "handtracking" as teleop_device, then we don't want all the headset anchoring code. Change the pre render callbacks to be a list so other systems can hook into it as well Rename classes from Controller to MotionController to limit confusion with Robotics controllers Move the code to alter the stage until after the telop device has been instantiated so we know what device we dealing with and if we need to change the ground plane material Format with ./isaaclab -f Update changelog, contributors and extension.toml Switch to rendering_dt instead of wall clock for determinism Address AI code review comments. Instead of having fixed heigh on by default, make it optional in the case of being able to go into crouch. We don't need to add pre render to ManagerBasedEnv since that can be done through XRCore. Moving new motion controller retargeters into new files Moving OpenXRDevice motion controller logic backup into OpenXRDevice, and moving interface enums into DeviceBase to remove retargeter dependancy on OpenXRDevice Adding retargeter requiremnts call Removing bespoke xr env adjustments Undo xr anchor height offset Cleaning up teleop script Code cleanup Update code comments Fix typo in RetargeterBase Properly set sim.device for retargeters Fixing greptile feedback Fix logic error if xr anchor rotation is disabled on AR startup Follow naming conventions for get_requirments
github-actions
bot
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there