-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Removes instances of IsaacSim SimulationContext
#4046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Removes instances of IsaacSim SimulationContext
#4046
Conversation
Greptile Summary
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Stage
participant CarbSettings
participant PhysX
participant USDContext
User->>Stage: attach_stage_to_usd_context(attaching_early)
Stage->>Stage: Check Isaac Sim version
Stage->>Stage: Check if stage is in memory
Stage->>PhysX: attach_stage(stage_id)
Stage->>CarbSettings: get("/physics/fabricUpdateTransformations")
CarbSettings-->>Stage: is_rendering_enabled
alt rendering enabled
Stage->>USDContext: attach_stage_with_callback(stage_id)
Stage->>PhysX: attach_stage(stage_id)
end
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 6 comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
| Args: | ||
| attaching_early: Whether to attach the stage to the usd context before stage is created. Defaults to False. | ||
| Whether to attach the stage to the usd context before stage is created. Defaults to False. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: parameter name missing in docstring - should be attaching_early: to match codebase standard (see nucleus.py or actuator_base.py for examples)
| Whether to attach the stage to the usd context before stage is created. Defaults to False. | |
| attaching_early: Whether to attach the stage to the usd context before stage is created. Defaults to False. |
| Args: | ||
| stage: The stage to set temporarily. | ||
| The stage to set temporarily. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: parameter name missing - should be stage: to match codebase standard
| The stage to set temporarily. | |
| stage: The stage to set temporarily. |
| Args: | ||
| predicate: user defined function that takes a prim_path (str) as input and returns True/False if the prim | ||
| predicate: user defined function that takes a prim_path as input and returns True/False if the prim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: parameter name missing - should be predicate: to match codebase standard
| predicate: user defined function that takes a prim_path as input and returns True/False if the prim | |
| predicate: user defined function that takes a prim_path as input and returns True/False if the prim |
| Args: | ||
| usd_path (str): Path to the USD file to open. | ||
| usd_path: Path to the USD file to open. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: parameter name missing - should be usd_path: to match codebase standard
| usd_path: Path to the USD file to open. | |
| usd_path: Path to the USD file to open. |
| Args: | ||
| usd_path (str): File path to save the current stage to | ||
| usd_path: File path to save the current stage to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: parameter name missing - should be usd_path: to match codebase standard
| usd_path: File path to save the current stage to | |
| usd_path: File path to save the current stage to |
| path: path we want to check | ||
| parent: Parent prim for the given path. Defaults to None. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: parameter names missing - should be path: and parent: to match codebase standard
| path: path we want to check | |
| parent: Parent prim for the given path. Defaults to None. | |
| path: path we want to check | |
| parent: Parent prim for the given path. Defaults to None. |
SimulationContext
Description
Cleans up new util functions
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there