fix: 删除已被忽略的hconfig.h
#673
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
按道理是应该删，但之前有Qt项目没有使用cmake，没法执行cmake configure或者./configure，所以提供了一份默认的hconfig.h |
Contributor
@ithewei |
|
确实是使用cmake编译后，老是提示 hconfig.h有改动，看看能不能考虑把hconfig.h去掉。如果是windows下要使用这份默认的hconfig.h，是不是可以在代码里面做出区分hconfig_win.h? 类unix系统使用自动生成的hconfig.h |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hconfig.h是自动生成的文件，并且已配置为忽略，应当删除原始文件，使配置生效。libhv/.gitignore
Line 65 in fded2ba
因为这个文件构建时会自动生成，让 git submodule 产生意外变更，造成一些不便。