Skip to content

Conversation

@staticssleever668
Copy link

@staticssleever668 staticssleever668 commented Mar 27, 2021

I also didn't add translations for the new option for some languages.

@MHBraun
Copy link
Contributor

MHBraun commented Mar 27, 2021

could you please give a brief description what this idea does?

@staticssleever668
Copy link
Author

Yes, of course. Currently in settings menu there are two options for user interface style: "dark" and "light". This patch adds third option - "follow system". Basically, it sets the "dark" or "light" style depending on dark mode (presumably sometimes it's called "night mode") being enabled in the system. In other words, if light theme is selected in the system, the app has light theme as well.
Looking at these changes back, I didn't test them in older Android versions. I guess it should fallback to 'light', but I'm not too sure. Reference.

@staticssleever668 staticssleever668 marked this pull request as draft March 4, 2022 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants