-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Formatted prompt to input time at login more logically #5513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Formatted prompt to input time at login more logically #5513
Conversation
|
I think you need to do the language changes on weblate. If i'm not mistaken @SamantazFox |
That makes sense, but is there a way to bulk edit a change like that in weblate? |
I'm sorry but I don't know. I do not use Weblate. |
Well, yes, and no. The answer is not very straightforward, so let me explain why. In this PR, you're doing two things: changing the "key" string, and changing the translated string. Difference between key and translated stringsThe keys are the left-most strings of the JSON files, and is what the The translated strings are the right-most strings of the same files and contain the actual text that will be seen by the user. For legacy reasons, the key and translated string were the same in english, but we started to clean that up to reduce confusion. As an example, here are some lines that were updated to better differentiate the two: Lines 72 to 80 in 5cfe294
How weblate detects changesThe
Note that changing a "key" is the same as deleting the line and adding a new one. Answer to the initial questionNow, if you only want to change the translated (source) string, that can now be done directly on Weblate, by editing the strings in the "english" language. As stated above, weblate will automatically mark strings in other languages as "unfinished" and primpt users for a translation. However, if you want to change the identifier ("key"), it can only be done here, because both the code and the JSON files must be changed. When you change both at the same time, make sure to only update the JSON files where you can ALSO update the translated strings. If you don't update them, Weblate won't be able to detect the change and thus mark them as "translated". For instance, if you speak english and german, only update the |
In this pull request, I changed the prompt for the task at signup to display "hh:mm:ss" instead of "h:mm:ss", because it more accurately tells the user, what to input. The actual formating is expected to be hh:mm:ss in the end anyways, because if you put in 8:22:03, you get an error message, in this case you need to input 08:22:03 to get through.