Fix evt.keyCode usage on IE6,7 #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On IE7- keyCode property is does not correspond to the key code.
The fixed issue is relevant on IE7. The 't' key, keyCode on IE7 is equal to 116, so is mapped to F5 key.
So, using {999} patern allows digit and 't' key since isSpecialKey(key) return true.
Owner
|
I am in the midst (about 90% complete) of implementing automated cross browser testing using sauce labs.This will fix the issue with your failing tests, as well as confirm that this change does not effect other various browsers. Thank you for the PR. |
I found the issue for keyPress/keyDown. http://www.west-wind.com/WestwindWebToolkit/samples/Ajax/html5andCss3/keycodechecker.aspx For keypress event does not map the keycode as keydown event. Why are there 2 key event managements? Any way, I've tested this PR on IE7, FF, Chrome and IE11.
Owner
|
Some fairly major changes have been pushed. Can you confirm this is still an issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On IE7- keyCode property is does not correspond to the key code.
The fixed issue is relevant on IE7. The 't' key, keyCode on IE7 is equal to 116, so is mapped to F5 key.
So, using {999} patern allows digit and 't' key since isSpecialKey(key) return true.