This repository was archived by the owner on Sep 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 22
[DATASOURCE]: Persistent data handler update #478
Open
amadolid
wants to merge
25
commits into
main
Choose a base branch
from
enhancements/persistent-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 24 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
4288413
[PERSISTENCE-PR-SERIES]: Initial Commit
amadolid dbd0878
[PERSISTENCE-PR-SERIES]: Architype Refactor
amadolid 7cd6c67
[PERSISTENCE-PR-SERIES]: Rename _jac_ and target_obj
amadolid 99c1701
[PERSISTENCE-PR-SERIES]: Context Refactor
amadolid 8b70518
[PERSISTENCE-PR-SERIES]: Memory Refactor
amadolid 562cf6d
[PERSISTENCE-PR-SERIES]: Plugin Refactor
amadolid a05f47e
[PERSISTENCE-PR-SERIES]: Align cli, constructs and jac_streamlit
amadolid 50bcb3c
[PERSISTENCE-PR-SERIES]: Unit Tests
amadolid 9ff2555
[PERSISTENCE-PR-SERIES]: Auto await if necessary
amadolid 79c1b6f
[UPDATES]: Address PR Comments
amadolid d1d810f
[ACCESS-VALIDATION]: Improved hierarchy of access level
amadolid f6ab241
[UNIT-TEST]: Access Validation
amadolid c540479
[ALIGNMENT]: Sync approach to jaclang-jaseci (Context and Memory)
amadolid b014909
[BUGFIX]: Missing EdgeAnchor.is_undirected & Rename NO_ACESSS
amadolid 4760372
[AUTOMATION]: Delete nodes that doesn't have any connection
amadolid db724ac
[DISCONNECT]: Use EdgeDir class instead of string
amadolid 2d68e4b
[REFACTOR]: Remove orjson and dacite
amadolid bdcc5f8
[REFACTOR]: Make Root and GenericEdge to be dataclass for consistency
amadolid 03533ee
[REFACTOR]: Prioritize pluggy context
amadolid 58ab554
[REFACTOR]: Remove ref_id prefixing
amadolid 9fbeaa7
[MINOR]: Return current root instead of super_root on get_object root
amadolid 2d7b101
[SERIALIZER]: Adjust pickling handler
amadolid 03dbf72
[CLEANUP]: Migrate some tools to jaclang-jaseci
amadolid d75fc1d
[MINOR]: Use shallow cloning instead of copy/deepcopy
amadolid a72b6c4
[UNIT-TEST]: Use JacFeature instead of ExecutionContext directly
amadolid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
41 changes: 0 additions & 41 deletions
41
examples/plugins/jaclang_walkerapi/jaclang_walkerapi/walkerapi.py
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should have this logic as a plugin method? like, how it is currently implemented in main.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, not sure which part you're pointing.
Will change the the == "root" to return current root instead of super root
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant the logic of getting the full object given an object id. I feel like this pattern gets used in a lot of places and it is something that a plugin might want to override.
So basically line 122 to 125.