-
-
Notifications
You must be signed in to change notification settings - Fork 631
Update type anotations #784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tor for type checks
450f457 to
b6c4c98
Compare
afb1da5 to
7361d21
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #784 +/- ##
==========================================
+ Coverage 72.75% 72.94% +0.18%
==========================================
Files 31 31
Lines 1259 1290 +31
Branches 207 214 +7
==========================================
+ Hits 916 941 +25
- Misses 300 301 +1
- Partials 43 48 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3e1b143 to
5bb195d
Compare
for more information, see https://pre-commit.ci
|
@50-Course Hi kindly check it out |
50-Course
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi again, thanks for this! We should call this in 🚀
jamaalscarlett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job. I found some missing Optional types, but other than that this is awesome.
This branch improves type safety and consistency across the codebase.
isinstancechecks._chunksusage to use the correct variables.returnin validator functions that never return.ManagerTypeas a union of the supported config classes.Union,Optional,List, andTuplefromtypingfor backwards compatibility (pre-3.10 support).