Skip to content

Conversation

@SebCorbin
Copy link
Contributor

No description provided.

@SebCorbin SebCorbin linked an issue Nov 20, 2022 that may be closed by this pull request
@SebCorbin SebCorbin force-pushed the 214-consider-using-django-20-execute_wrapper branch from 1b76012 to 23917b8 Compare November 20, 2022 18:22
@SebCorbin SebCorbin requested a review from a team November 20, 2022 18:22
@codecov
Copy link

codecov bot commented Nov 20, 2022

Codecov Report

❌ Patch coverage is 95.55556% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.77%. Comparing base (5677fa8) to head (1d0d131).
⚠️ Report is 118 commits behind head on master.

Files with missing lines Patch % Lines
silk/sql.py 94.73% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #631      +/-   ##
==========================================
+ Coverage   86.33%   86.77%   +0.43%     
==========================================
  Files          52       52              
  Lines        2093     2094       +1     
==========================================
+ Hits         1807     1817      +10     
+ Misses        286      277       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SebCorbin SebCorbin force-pushed the 214-consider-using-django-20-execute_wrapper branch from d8ebb11 to 9c2e38a Compare November 20, 2022 19:25
@ulgens
Copy link
Member

ulgens commented Nov 20, 2022

@SebCorbin Can you please give some details about this PR and its purpose? Thank you.

@SebCorbin
Copy link
Contributor Author

SebCorbin commented Nov 20, 2022

@ulgens yes, see the related issue and last comment #214 (comment)

@SebCorbin SebCorbin force-pushed the 214-consider-using-django-20-execute_wrapper branch from 9c2e38a to c186f40 Compare November 20, 2022 22:43
@SebCorbin SebCorbin mentioned this pull request Nov 21, 2022
@SebCorbin
Copy link
Contributor Author

After few days of real-world testing, the ready() method is not development-proof with the runserver command. I'll update this PR to switch to classic context manager on the middleware.

@SebCorbin SebCorbin marked this pull request as draft December 14, 2022 09:42
@SebCorbin SebCorbin self-assigned this Jan 9, 2023
@SebCorbin
Copy link
Contributor Author

Another option: rely on connection_created signal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider using Django 2.0 execute_wrapper()

2 participants