Get paginator limit from url params #646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When profiling requests with a huge number of queries sometimes we end up with multiple pages. This will allow the user to specify a page size via URL params.
albertyw
reviewed
Jun 26, 2025
silk/utils/pagination.py
Outdated
|
|
||
| def _page(request, query_set): | ||
| paginator = Paginator(query_set, 200) | ||
| per_page = request.GET.get('per_page', 200) |
Member
There was a problem hiding this comment.
let's make sure this is actually an int, especially because the input is coming from an external source.
Contributor
Author
|
@albertyw thanks, good call. Added a check and default value for the page size, and updated tests. I've also added a selector in the top bar: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When profiling requests with a huge number of queries sometimes we end up with multiple pages. Since the sql page only sorts current lines it's hard to see all the heaviest queries on one page and there's no way to see more than 200 since the limit is hardcoded.
This will allow the user to specify a page size via URL param e.g.
&per_page=300.