Skip to content

Conversation

@webknjaz
Copy link
Member

It is supposed to correspond to the range of what's tested in our CI.

Contributor checklist
  • Included tests for the changes.
  • A change note is created in changelog.d/ (see changelog.d/README.md for instructions) or the PR text says "no changelog needed".
Maintainer checklist
  • If no changelog is needed, apply the skip-changelog label.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

It is supposed to correspond to the range of what's tested in our CI.
@webknjaz webknjaz added this to the later milestone Oct 30, 2025
@webknjaz webknjaz requested review from Copilot and sirosen October 30, 2025 16:13
Copy link
Member Author

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need some sort of linting for keeping these in sync w/ CI and perhaps docs.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces version constraints for pip to ensure compatibility testing. It adds a new optional dependency group called supported-pip that limits pip to versions below 25.3, and integrates this constraint into the tox testing environments for pipsupported and piplowest configurations.

  • Added a new supported-pip optional dependency group in pyproject.toml with pip version constraint < 25.3
  • Updated tox configuration to use the supported-pip extras for pipsupported and piplowest test environments

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pyproject.toml Adds supported-pip optional dependency group with pip version constraint
tox.ini Integrates supported-pip extras into pipsupported and piplowest test environments

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@sirosen sirosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am trying to decide what we should name this extra -- not taking it as a given that the proposed name, supported-pip, is best.

I think supported-pip may be confusing if we start pinning anything other than pip in the future. And I think we should at least start with pip-only, which makes the possibility of such confusion stronger in the future. So I think we should remove pip from the name of the extra.

That would leave us with pip-tools[supported], which I think is good. I can't come up with anything better, at least!

@webknjaz
Copy link
Member Author

webknjaz commented Nov 5, 2025

I think supported-pip may be confusing if we start pinning anything other than pip in the future. And I think we should at least start with pip-only, which makes the possibility of such confusion stronger in the future. So I think we should remove pip from the name of the extra.

That would leave us with pip-tools[supported], which I think is good. I can't come up with anything better, at least!

That's a good point. Alternatively, we could have multiple composable extras and the users could use pip-tools [supported-click, supported-pip].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants