-
-
Notifications
You must be signed in to change notification settings - Fork 634
📦 Add pip-supported extra for upper bound
#2257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
It is supposed to correspond to the range of what's tested in our CI.
webknjaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need some sort of linting for keeping these in sync w/ CI and perhaps docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces version constraints for pip to ensure compatibility testing. It adds a new optional dependency group called supported-pip that limits pip to versions below 25.3, and integrates this constraint into the tox testing environments for pipsupported and piplowest configurations.
- Added a new
supported-pipoptional dependency group inpyproject.tomlwith pip version constraint< 25.3 - Updated tox configuration to use the
supported-pipextras forpipsupportedandpiplowesttest environments
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Adds supported-pip optional dependency group with pip version constraint |
| tox.ini | Integrates supported-pip extras into pipsupported and piplowest test environments |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sirosen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am trying to decide what we should name this extra -- not taking it as a given that the proposed name, supported-pip, is best.
I think supported-pip may be confusing if we start pinning anything other than pip in the future. And I think we should at least start with pip-only, which makes the possibility of such confusion stronger in the future. So I think we should remove pip from the name of the extra.
That would leave us with pip-tools[supported], which I think is good. I can't come up with anything better, at least!
That's a good point. Alternatively, we could have multiple composable extras and the users could use |
It is supposed to correspond to the range of what's tested in our CI.
Contributor checklist
changelog.d/(seechangelog.d/README.mdfor instructions) or the PR text says "no changelog needed".Maintainer checklist
skip-changeloglabel.