Skip to content

🧪 Improve Codecov integration stability #2265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 8, 2025
+37 −2
Merged

🧪 Improve Codecov integration stability #2265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0280d1c
🧪 Ensure Codecov reports are uploaded on fail
webknjaz Nov 7, 2025
2fed7c6
🧪💅 Make Codecov config dot-prefixed
webknjaz Nov 7, 2025
12c05e2
🧪 Notify Codecov about upload completions
webknjaz Nov 7, 2025
b0730a6
📝 Add a change note for PR #2265
webknjaz Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---

codecov:
notify:
manual_trigger: true # prevent notifications until we notify Codecov

require_ci_to_pass: false

comment: false # avoid spamming reviews

...
Copy link
Member

@sirosen sirosen Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is an ellipsis a special kind of YAML node? I don't recall this one, but there are so many exotic features in YAML that I'm slow to assume that it's a mistake.

Copy link
Member Author

@webknjaz webknjaz Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a marker of the end. Totally optional. I just like it there and it got copied from another project.

A multi-document YAML file might look like this:

---

doc1: stuff

---

doc2: things

---

doc3: the rest

...

20 changes: 19 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,8 @@ jobs:
shell: bash
- name: Upload coverage to Codecov
if: >-
!inputs.cpython-pip-version
!cancelled()
&& !inputs.cpython-pip-version
uses: codecov/codecov-action@v5
with:
files: ./coverage.xml
Expand Down Expand Up @@ -254,6 +255,23 @@ jobs:
&& exit 1
shell: bash

coverage-summary:
name: Coverage processing
if: >-
!cancelled()
runs-on: ubuntu-latest
timeout-minutes: 1
needs:
- test
steps:
- name: Notify Codecov that all coverage reports have been uploaded
if: >-
!cancelled()
uses: codecov/codecov-action@v5
with:
fail_ci_if_error: true
run_command: send-notifications

check: # This job does nothing and is only used for the branch protection
if: always()

Expand Down
7 changes: 7 additions & 0 deletions changelog.d/2265.contrib.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
The integration with Codecov has been updated to ensure that reports
are uploaded to the service even on failures -- by {user}`webknjaz`.

GitHub Actions is now configured to also send an explicit notification
to Codecov about the completion of previously initiated uploads.

Additionally, the configuration file is now {file}`.codecov.yml`.
1 change: 0 additions & 1 deletion codecov.yml
View file
Open in desktop

This file was deleted.

Loading