Bitrot fixed #21
Open
Bitrot fixed #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*** lists/index.js:
Changed to return first element of key array rather than entire
array.
*** views/lib/comments.js:
Apparently, from within maps, CouchDB will only include files from
the 'views/lib/' tree. Also changed to be more conformant to
CommonJS require standards used elsewhere in the app. (This was the
only macro invocation I could find in the entire project)
*** views/lib/md5.js:
Added file so views/lib/comments.js could 'require' it.
*** views/post-page/map.js:
Wasn't sorting properly, so nothing was being displayed, CouchDB
reported 'getRow() is null'.
*** _attachments/script/md5.js:
Added conditional 'export' statement
*** evently/profile/profileReady/selectors/#preview/click.js:
Removed extra parameter to Mustache.escape() which was causing an
empty string to be returned.
*** helpers/md5.js:
Added 'export' statement
*** templates/edit.html:
Correct post action
*** templates/post.html:
Needed to be a 'div' for evently logic to use. Added script
jquery.scrollTo.js
*** ERRATA.md
Added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Please disregard the previous pulll request, one of the md5.js files was re-added mistakenly)
Hallo,
Sofa is such an interesting little program, I just had to get it working! Thanks so much for sharing it.
Here are the changes I made, hope you find them useful. :)
I tried to make the changes as minimal as possible, and refrain from making 'improvements'. (I plan to do that in a separate project, now that its working, thinking of 'sofa-ng')
Chris (J) Hall, aka bitmonki
[email protected]