Bump versions in workflows #516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Should the version matrix perhaps align with Jekyll 4.x https://github.com/jekyll/jekyll/blob/master/.github/workflows/ci.yml#L25-L30 + Ruby 2.5 as the lowest supported version? |
So that `ruby/setup-ruby` actions installs a version of **Rubygems** newer than `2.7.6.3`. Newer versions of Rubygems contain a patch that allows Bundler to honour `required_ruby_version` directive properly
Contributor
Author
|
If CI jobs are running against 2.7, should the minimum Ruby requirement for this gem be bumped too? |
Member
Not necessarily. The plugin can still be installed and run on Ruby 2.5 and Ruby 2.6 (albeit no longer tested with and therefore no longer recommended). |
ashmaroli
approved these changes
May 5, 2025
Member
|
Thanks @CookiePLMonster |
jekyllbot
added a commit
that referenced
this pull request
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kept 2.5 in the build matrix as it's the lowest supported Ruby version in the
.gemspecfile. I'm not sure if it makes sense to keep 2.7 around, so I instead opted for the currently supported versions. For CI actions that deal with both Jekyll 3.x and 4.x, I opted to use Ruby 3.2 as the oldest currently maintained version, as Jekyll 3.x doesn't work with Ruby 3.4 due to thebase64dependency no longer being part of the standard library. For tests, I wasn't sure what Ruby version to use so I left it at 2.5.