Skip to content

Conversation

@felix920506
Copy link
Member

move to using tabs instead of having everything listed together on the same page.
The default tab will be selected based on the current page that is being viewed

@linkandzelda91
Copy link
Contributor

should movies and shows be unified into a "dedicated movies or shows" page and go all in on the tabs for each section? feels weird that they dup on content for eachother.

image

@felix920506
Copy link
Member Author

@linkandzelda91 see discussion here for why it's separate pages. #1374 (comment)

Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to use the query string feature of the tabs component so documentation stays easily sharable.

@jellyfin-bot
Copy link

Cloudflare Pages deployment

Latest commit 431cf451ed27b83c78a73af5884b88b86644d1ed
Status ✅ Deployed!
Preview URL https://2b5b352f.jellyfin-org.pages.dev
Type 🔀 Preview

Copy link
Member

@BotBlake BotBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As previously discussed in the documentation room, it should be more clear what is part of the Tab.

I have created a mockup by modifying the css in the browser direcly.
grafik

I dont KNOW if you can modify the styling directly, but if you can, here is the css snippet I used to make the borders there.

.tabs-container.tabList__CuJ {
  border: 2px solid rgba(255, 255, 255, 0.2);
  border-radius: 8px;
  padding: 16px;
  box-shadow: 0 0 8px rgba(255, 255, 255, 0.2); /* fancy glowy shizz that I realy like */
}

@felix920506
Copy link
Member Author

blocked by #1564

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants