-
-
Notifications
You must be signed in to change notification settings - Fork 523
use tabs for metadata docs that covers multiple library types #1495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@linkandzelda91 see discussion here for why it's separate pages. #1374 (comment) |
nielsvanvelzen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to use the query string feature of the tabs component so documentation stays easily sharable.
Cloudflare Pages deployment
|
BotBlake
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As previously discussed in the documentation room, it should be more clear what is part of the Tab.
I have created a mockup by modifying the css in the browser direcly.

I dont KNOW if you can modify the styling directly, but if you can, here is the css snippet I used to make the borders there.
.tabs-container.tabList__CuJ {
border: 2px solid rgba(255, 255, 255, 0.2);
border-radius: 8px;
padding: 16px;
box-shadow: 0 0 8px rgba(255, 255, 255, 0.2); /* fancy glowy shizz that I realy like */
}|
blocked by #1564 |

move to using tabs instead of having everything listed together on the same page.
The default tab will be selected based on the current page that is being viewed