Skip to content

Conversation

@jatjhu
Copy link

@jatjhu jatjhu commented Jun 23, 2022

…or jhuid

@github-actions
Copy link

This PR has no dependency differences with the base branch

@DonRichards
Copy link
Member

@jatjhu How do I test this?

@jatjhu
Copy link
Author

jatjhu commented Sep 15, 2022

@DonRichards pull this down and go to the site as an anonymous user. The login link should not appear.
If you got to /jhlogin, it should start the saml sign in process.

@ghost
Copy link

ghost commented Sep 26, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@github-actions
Copy link

This PR has no dependency differences with the base branch

@github-actions
Copy link

This PR has no dependency differences with the base branch

@DonRichards
Copy link
Member

@jatjhu I tried this a few times and couldn't get it to work. Is there anything special about when & when it would work? Is it supposed to work on our local environment or just when it's deployed with JHED auth enabled?

DonRichards pushed a commit that referenced this pull request Aug 2, 2024
Makefile additions for building and pushing custom images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants