Skip to content

[5.4] Expose finalization errors in autoupdate API response #46493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 5.4-dev
Choose a base branch
from
+8 −2
Open

[5.4] Expose finalization errors in autoupdate API response #46493

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cea629
expose finalization errors in api response
SniperSister Nov 25, 2025
6fe1d5e
Update api/components/com_joomlaupdate/src/View/Updates/JsonapiView.php
SniperSister Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions api/components/com_joomlaupdate/src/View/Updates/JsonapiView.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,13 +136,19 @@ public function finalizeUpdate($fromVersion, $updateFileName)
$model->resetUpdateSource();

$success = true;
$errors = [];

// Append any errors to the API response for debugging purposes
if ($model->getErrors()) {
$success = false;

$errors = array_map(function ($error) {
return (string) $error;
}, $model->getErrors());
}

$element = (new Resource((object) ['success' => $success, 'id' => 'finalizeUpdate'], $this->serializer))
->fields(['updates' => ['success']]);
$element = (new Resource((object) ['success' => $success, 'id' => 'finalizeUpdate', 'errors' => $errors], $this->serializer))
->fields(['updates' => ['success', 'errors']]);

$this->getDocument()->setData($element);
$this->getDocument()->addLink('self', Uri::current());
Expand Down
Loading