Skip to content

Conversation

@PavelKopecky
Copy link
Contributor

Closes #837

@coderabbitai
Copy link

coderabbitai bot commented Nov 8, 2025

Walkthrough

This PR adds CodeRabbit as a bronze sponsor on the sponsors page. Changes include inserting CodeRabbit sponsor tiles in two locations within the Bronze sponsor row in the HTML template, and implementing responsive styling for sponsor images with a 240px max-width constraint on small viewports and unrestricted width on larger screens (576px and above).

Possibly related issues

No additional related issues identified. The linked issue #837 directly corresponds to these changes.

Suggested reviewers

  • MartinKolarik

Poem

🐰 CodeRabbit hops into the Bronze row,
With logos that gracefully grow,
Responsive and neat,
Making sponsors complete,
A new partnership ready to show! 🎉

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main change: adding CodeRabbit as a bronze sponsor, which matches the changeset modifications.
Description check ✅ Passed The description references the related issue #837 and aligns with the PR objective of adding CodeRabbit to bronze sponsors.
Linked Issues check ✅ Passed The pull request implements the requirement from issue #837 to add CodeRabbit as a new bronze sponsor by adding the sponsor tile and styling.
Out of Scope Changes check ✅ Passed All changes are scoped to adding CodeRabbit as a bronze sponsor: HTML markup for the sponsor tile and CSS styling for sponsor image sizing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch gh-837

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 630fed3 and 8be3c28.

⛔ Files ignored due to path filters (1)
  • src/assets/img/sponsors/code-rabbit.svg is excluded by !**/*.svg
📒 Files selected for processing (2)
  • src/assets/less/pages/sponsors.less (1 hunks)
  • src/views/pages/sponsors.html (1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: xbpcb
Repo: jsdelivr/www.jsdelivr.com PR: 768
File: src/assets/less/pages/globalping/sponsors.less:199-199
Timestamp: 2025-05-29T18:11:35.594Z
Learning: In sponsor card designs (like in src/assets/less/pages/globalping/sponsors.less), fixed height values are intentionally used instead of min-height to maintain layout consistency, especially for "become-a-sponsor" items where visual uniformity is important for the design.
Learnt from: xbpcb
Repo: jsdelivr/www.jsdelivr.com PR: 765
File: src/views/pages/globalping/sponsors.html:331-337
Timestamp: 2025-05-22T18:00:47.692Z
Learning: Sponsor images in the jsDelivr website may intentionally have different dimensions on different pages (such as in sponsors.html vs _index.html) to match design requirements. This is normal and should not be flagged as an inconsistency.
Learnt from: PavelKopecky
Repo: jsdelivr/www.jsdelivr.com PR: 811
File: src/views/pages/globalping/_users.html:20-27
Timestamp: 2025-09-04T15:39:12.792Z
Learning: PavelKopecky prefers not to add alt attributes to images in HTML templates, even for accessibility purposes.
Learnt from: PavelKopecky
Repo: jsdelivr/www.jsdelivr.com PR: 811
File: src/assets/less/pages/globalping/users.less:45-59
Timestamp: 2025-09-14T10:00:21.267Z
Learning: PavelKopecky uses left/right positioning with equal values (e.g., left: 32px; right: 32px;) combined with max-width and margin: 0 auto for centering absolutely positioned elements, and prefers this approach over transform-based centering.
Learnt from: PavelKopecky
Repo: jsdelivr/www.jsdelivr.com PR: 814
File: src/views/pages/globalping/_networks.html:240-242
Timestamp: 2025-09-17T15:38:13.333Z
Learning: PavelKopecky prefers OTHER_NETWORKS_DISPLAYED = 12 (showing 6 neighbors on each side) for the "Explore other networks" section in the Globalping networks page, rather than 20 neighbors as might be suggested by spec examples.
📚 Learning: 2025-05-29T18:11:35.594Z
Learnt from: xbpcb
Repo: jsdelivr/www.jsdelivr.com PR: 768
File: src/assets/less/pages/globalping/sponsors.less:199-199
Timestamp: 2025-05-29T18:11:35.594Z
Learning: In sponsor card designs (like in src/assets/less/pages/globalping/sponsors.less), fixed height values are intentionally used instead of min-height to maintain layout consistency, especially for "become-a-sponsor" items where visual uniformity is important for the design.

Applied to files:

  • src/assets/less/pages/sponsors.less
  • src/views/pages/sponsors.html
📚 Learning: 2025-05-22T18:00:47.692Z
Learnt from: xbpcb
Repo: jsdelivr/www.jsdelivr.com PR: 765
File: src/views/pages/globalping/sponsors.html:331-337
Timestamp: 2025-05-22T18:00:47.692Z
Learning: Sponsor images in the jsDelivr website may intentionally have different dimensions on different pages (such as in sponsors.html vs _index.html) to match design requirements. This is normal and should not be flagged as an inconsistency.

Applied to files:

  • src/assets/less/pages/sponsors.less
  • src/views/pages/sponsors.html
🔇 Additional comments (1)
src/views/pages/sponsors.html (1)

268-274: No issues found.

The CodeRabbit sponsor image asset exists at the expected location, and the tile structure is correctly integrated.


Comment @coderabbitai help to get the list of available commands and usage tips.

@jimaek jimaek temporarily deployed to gh-837 - www.jsdelivr.com PR #838 November 8, 2025 12:59 — with Render Destroyed
@MartinKolarik MartinKolarik merged commit 438104d into master Nov 10, 2025
2 checks passed
@MartinKolarik MartinKolarik deleted the gh-837 branch November 10, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New bronze sponsor: CodeRabbit

4 participants