Changed fstab generation #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Using shell module instead of command to generate fstab. Command module does not support stdout redirection. Therefor the genfstab script did not work. This is now changed to the shell module which support stdout redirection. Therefore, the different mounted devices do not have to be entered into the fstab manually but will be added by genfstab. * Additionally, added a warn=false to the curl command
Owner
|
Thanks for the pull request @bittnert, and apologies for not noticing it until now. I will review this as soon as I have time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using shell module instead of command to generate fstab.
Command module does not support stdout redirection. Therefor the genfstab script did not work.
This is now changed to the shell module which support stdout redirection. Therefore, the
different mounted devices do not have to be entered into the fstab manually but will be added
by genfstab.
Additionally, added a warn=false to the curl command