Skip to content

Conversation

@dictcp
Copy link
Contributor

@dictcp dictcp commented Nov 18, 2025

Enable CUDA build for ARM64

Since there are ARM64 platform like DGX spark, we need CUDA build for ARM64.
(give DGX spark case, given it requires CUDA capacity of 12.1, so latest CUDA is fine)

Checklist (especially for first-time contributors)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I will try not to use force-push to make the review process easier for reviewers
  • I have updated the documentation for significant changes

@dictcp dictcp mentioned this pull request Nov 18, 2025
4 tasks
@dictcp dictcp marked this pull request as ready for review November 18, 2025 17:08
Copilot AI review requested due to automatic review settings November 18, 2025 17:08
Copilot finished reviewing on behalf of dictcp November 18, 2025 17:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for CUDA-enabled Docker images on ARM64 (aarch64) architecture to support platforms like NVIDIA DGX Spark. It introduces two new workflow jobs for building TensorFlow and PyTorch notebooks with CUDA support on aarch64 and adds these jobs to the dependency chain in the tag-push workflow.

  • Adds aarch64-tensorflow-cuda job using CUDA variant
  • Adds aarch64-pytorch-cuda12 job using CUDA 12 variant
  • Updates tag-push workflow dependencies to include the new aarch64 CUDA jobs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dictcp dictcp requested a review from Copilot November 18, 2025 18:01
Copilot finished reviewing on behalf of dictcp November 18, 2025 18:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dictcp dictcp requested a review from Copilot November 20, 2025 05:14
Copilot finished reviewing on behalf of dictcp November 20, 2025 05:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@benz0li
Copy link
Contributor

benz0li commented Nov 20, 2025

@mathbunnyru I think you need to change the first item in the checklist from

I have performed a self-review of my code

to

I, or Copilot on my behalf, have performed a review of the code

@dictcp dictcp marked this pull request as draft November 20, 2025 10:21
@mathbunnyru mathbunnyru marked this pull request as ready for review December 2, 2025 19:02
@mathbunnyru
Copy link
Member

@dictcp I worked on this PR, it should build fine now

@mathbunnyru
Copy link
Member

@mathbunnyru I think you need to change the first item in the checklist from

I have performed a self-review of my code

to

I, or Copilot on my behalf, have performed a review of the code

I would probably say that I still want people to take a look at their PRs, and essentially, this check should be marked and done before submitting the PR (and Copilot can't do that).

@mathbunnyru
Copy link
Member

mathbunnyru commented Dec 2, 2025

Failing CI is due to an attempt to merge commit-hash-based tags, which are not pushed from PRs. Will have to fix it later, but this change seems good to go. (this issue is unrelated to this PR at all)

@mathbunnyru mathbunnyru merged commit 641b7db into jupyter:main Dec 2, 2025
57 of 71 checks passed
@mathbunnyru
Copy link
Member

@dictcp thank you for the contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants