Require --config to specify a file in the current working directory #260
+19
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't constrain the --config flag to only work with files in the
current working directory, things won't behave as expected.
The project has been explicit about saying that paths resolve relative
to the config files that specify the paths, but if --config is allowed
to reference paths outside the current working directory chartpress no
longer honors its documented behavior.
Due to this, I think we should instead fail loudly than let users
experience weird behavior if --config file references a file outside the
current working directory.