Skip to content

Conversation

@adilGhaffarDev
Copy link
Contributor

this PR fixes: #540
it was breaking image push with following error:

[Invalid workflow file: .github/workflows/image-push-master.yml#L10](https://github.com/k8snetworkplumbingwg/sriov-network-device-plugin/actions/runs/9091929799/workflow)
The workflow is not valid. .github/workflows/image-push-master.yml (Line: 10, Col: 9): Unrecognized named-value: 'env'. Located at position 28 within expression: github.repository_owner == env.image-push-owner .github/workflows/image-push-master.yml (Line: 41, Col: 9): Unrecognized named-value: 'env'. Located at position 28 within expression: github.repository_owner == env.image-push-owner

This PR has moved the if further in the tree where env is accessible.

@zeeke
Copy link
Member

zeeke commented May 15, 2024

Can you please merge this branch in your repository master? So we'd be sure the syntax is not broken

Signed-off-by: adil ghaffar <[email protected]>
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9094134752

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.1%

Totals Coverage Status
Change from base Build 9091929803: 0.0%
Covered Lines: 2060
Relevant Lines: 2743

💛 - Coveralls

@adilGhaffarDev
Copy link
Contributor Author

Can you please merge this branch in your repository master? So we'd be sure the syntax is not broken

I added a fix and tried it on my fork, The image pushes passes (skipped) but push-manifest fails, I need to check that. https://github.com/adilGhaffarDev/sriov-network-device-plugin/actions/runs/9094211979
I will investigate. Lets revert the PR for now

@SchSeba
Copy link
Collaborator

SchSeba commented Aug 19, 2024

Hi @adilGhaffarDev any update on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants