Skip to content

Additions to Mrf24j40 arduino library #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sivanovbg wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Additions to Mrf24j40 arduino library #4

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dcf544
Update mrf24j.cpp
sivanovbg Feb 2, 2017
a61163a
Update mrf24j.h
sivanovbg Feb 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mrf24j.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,8 @@ class Mrf24j
void set_palna(boolean enabled);

void send16(word dest16, char * data);

void send16(word dest16, char * data, byte length);
Copy link
Owner

@karlp karlp Feb 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should make the header change in the same commit as the .cpp change. Each individual commit should contain what is needed for the change. By splitting the commits in two, you have a commit that doesn't compile properly.

You can use git rebase to squish them back into one commit.


void interrupt_handler(void);

Expand Down