Skip to content

Conversation

@candywater
Copy link

@candywater candywater commented May 31, 2025

This issue has been around for a while.

On Windows 10 (22H2), Keybase couldn't clear the unread badge icon.
The red notification badge would stay visible until I closed the Keybase window and reopened it from the taskbar's system tray area.
image

It's working properly after this fix.
This error introduced from 2023 Dec 8.

@candywater candywater changed the title fix: fix cannot clear unread icon in taskbar issue fix: fix cannot clear unread icon in taskbar issue (win10) May 31, 2025
@candywater
Copy link
Author

candywater commented May 31, 2025

looks like introduced by

#25648
https://github.com/keybase/client/pull/25648/files?file-filters%5B%5D=.tsx&show-viewed-files=true&show-deleted-files=false

file: shared/desktop/app/menu-bar.desktop.tsx

original code

mw?.setOverlayIcon(overlay, 'new activity')

new code

overlay && mw?.setOverlayIcon(Electron.nativeImage.createFromPath(overlay), 'new activity')

in original code, overlay could be null, so it worked fine
but in new code after 2023 Dec 8, it will never call
mw?.setOverlayIcon(null, 'new activity')
so it gets errors.

@candywater candywater mentioned this pull request May 31, 2025
@candywater
Copy link
Author

hi @chrisnojima will this fix be included into next release ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant