Skip to content

fix: improve assets path resolution for static pages #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: improve assets path resolution for static pages #187

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a94ae62
fix: improve assets path resolution for static pages
rafalynch Mar 28, 2025
46b85b5
fix: correct resource path resolution logic
rafalynch Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion @kindspells/astro-shield/src/core.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,13 @@ export const updateStaticPageSriHashes = async (
const updatedSrc = src.startsWith(base)
? src.replace(base, '')
: src
const resourcePath = resolve(distDir, `.${updatedSrc}`)

// Prepare a relative path for resolve - depending on a trailing slash on base above
// after removing it, updatedSrc may or may not start with a slash
const resourcePath = resolve(
distDir,
updatedSrc.startsWith('/') ? `.${updatedSrc}` : updatedSrc,
)
resourceContent = await readFile(resourcePath)
} else {
// TODO: should we remove the element?
Expand Down