Skip to content

Conversation

@MohitMaliFtechiz
Copy link
Collaborator

Fixes #4500

This happened because some devices do not support this explicit intent, as there is no universal direct intent for opening the hotspot screen. A common intent is available for opening the "Wireless settings" screen, so we use that as a fallback. If the device supports the direct intent, the hotspot screen opens directly; otherwise, the Wireless settings screen is opened instead, and the user can turn on the hotspot from there.

* This happened because some devices do not support this explicit intent, as there is no universal direct intent for opening the hotspot screen. A common intent is available for opening the "Wireless settings" screen, so we use that as a fallback. If the device supports the direct intent, the hotspot screen opens directly; otherwise, the Wireless settings screen is opened instead, and user can on the hotspot from there.
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.95%. Comparing base (55a599a) to head (401e471).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...org/kiwix/kiwixmobile/webserver/ZimHostFragment.kt 0.00% 10 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4501      +/-   ##
============================================
- Coverage     59.08%   58.95%   -0.14%     
+ Complexity     1500     1495       -5     
============================================
  Files           319      319              
  Lines         17109    17113       +4     
  Branches       2133     2134       +1     
============================================
- Hits          10109    10089      -20     
- Misses         5600     5615      +15     
- Partials       1400     1409       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kelson42 kelson42 merged commit 3bf552a into main Nov 18, 2025
56 of 59 checks passed
@kelson42 kelson42 deleted the Fixes#4500 branch November 18, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Someone has reported a crash TetherSettings activity not found.

4 participants