Skip to content

Conversation

@masterleinad
Copy link
Contributor

dalg24
dalg24 previously requested changes May 18, 2023
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You accidentally pushed documentation for printf

@masterleinad masterleinad force-pushed the exec_space_completion_query branch from 8b3a04f to 949a06b Compare May 18, 2023 21:14
@masterleinad masterleinad requested a review from dalg24 May 18, 2023 21:14
@masterleinad
Copy link
Contributor Author

You accidentally pushed documentation for printf

Fixed.

Copy link
Contributor

@ajpowelsnl ajpowelsnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

* ``const char* name() const;``: *Returns* the label of the execution space instance.

* ``bool is_running() const;``: *Returns* ``true`` if the execution space is currently executing a kernel, otherwise returns ``false``. Therefore, if the function returns ``false``, all kernels submitted by the current thread have been completed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Group comment:

  • Revisit once code PR finalized

Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Reacting to the agenda for the documentation session next Tuesday, Jan 16th)
This is NOT ready to merge. The work it is documenting is a draft PR and has not been merged

@masterleinad masterleinad marked this pull request as draft January 11, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants