Run coverage against test folder #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to the src/ folder, the tests/ folder can also have dead paths or misconfiguration in test functions or fixtures that may lead to dead tests, or false assumptions about what is being tested. This change will start looking for lack of coverage on files in the tests/ folder, and should help with finding out what these tests are in the future.
This commit addresses the lines where codecoverage didn't hit in the
test_timeouts.py file.
The _Leaky class is designed to never hit certain code paths, and
because of that codecoverage will complain. This is expected, however,
and codecoverage can be ignored in these cases.
As for tests containing context managers like this:
with pytest.raises(...):
with timeouts.apply_timeouts(
using="default",
lock_timeout=lock_timeout,
statement_timeout=statement_timeout,
):
# This line will never be hit, because the context manager
# raises before it can run.
pass
An alternative would be to call __enter__() manually:
timeouts.apply_timeouts(
using="default",
lock_timeout=lock_timeout,
statement_timeout=statement_timeout,
).__enter__()
But that looks a bit unergonomic, and isn't the way this is used in
practice. Instead, a # pragma: no cover was slapped on it.
Coverage Report Results
6 empty files skipped. |
marcelofern
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so codecoverage also runs in the
tests/folder.