Handle scenario where unique constraint with expression(s) is provided #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesGriffin
force-pushed
the
unique-constraint/with-expressions
branch
from
313f340 to
46fc4c6
Compare
marcelofern
approved these changes
Jul 6, 2025
Contributor
marcelofern
left a comment
marcelofern
left a comment
There was a problem hiding this comment.
Nice! The coverage job isn't running (don't know why) - it seems like a permission given that you're running from a fork. It passes locally on the branch though:
---------------------------------------------------------------------------------------------------------------------
src/django_pg_migration_tools/indexes.py 9 0 0 0 100%
src/django_pg_migration_tools/management/commands/migrate_with_timeouts.py 138 0 20 0 100%
src/django_pg_migration_tools/operations.py 453 0 90 0 100%
src/django_pg_migration_tools/timeouts.py 73 0 30 0 100%
tests/django_pg_migration_tools/management/commands/test_migrate_with_timeouts.py 126 0 0 0 100%
tests/django_pg_migration_tools/test_indexes.py 33 0 0 0 100%
tests/django_pg_migration_tools/test_operations.py 1740 0 0 0 100%
tests/django_pg_migration_tools/test_package.py 3 0 0 0 100%
tests/django_pg_migration_tools/test_timeouts.py 75 0 0 0 100%
---------------------------------------------------------------------------------------------------------------------
TOTAL 2650 0 140 0 100%
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where a unique constraint with expressions produces invalid SQL when used with
SaferAddUniqueConstraintandSaferRemoveUniqueConstraint.These changes are based on a previous PR which solved a similar issue for unique constraints with conditions.