Fix: Fix to_field being ignored for SaferAddFieldForeignKey migrations
#94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `to_field` parameter can be explicitly provided to the django `ForeignKey` interface, however we were defaulting to always use the pk of the related model. This led to a regression where django would think the ForeignKey relationship was operating over the specified `to_field`, but the database column type was incorrect.
dan-wilton
force-pushed
the
foreignkeys/bugfix-safer-add-field-foreign-key-explicit-to-field
branch
from
9ae3966 to
ec336d5
Compare
LilyFirefly
approved these changes
Nov 18, 2025
marcelofern
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
to_fieldparameter can be explicitly provided to the djangoForeignKeyinterface, however we were defaulting to always use the pk of the related model.This has led to a regression where django would think the
ForeignKeyrelationship was operating over the specifiedto_field, but the database column type was incorrect.