-
Notifications
You must be signed in to change notification settings - Fork 6
Add explanation for testing after-commit callbacks #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
meshy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! I think some of the examples might have gone a little astray in translating from our internal docs, so will need some fixing.
|
Thought: Because each example has slightly different code and tests, perhaps we could put them both side-by-side with https://squidfunk.github.io/mkdocs-material/reference/grids/#using-generic-grids |
da63446 to
0176606
Compare
Grids seem promising - I tried to arrange it using grid but wasn't able to find a way to present the information in an intuitive way, so I re-arranged the code a bit (the screenshot in the description is also updated). Let me know what you think! |
0176606 to
2cc064d
Compare
2cc064d to
ac6598b
Compare
7f5eedc to
87bf7ad
Compare
meshy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some things to consider before our pairing session:
e11808b to
3ecff46
Compare
3ecff46 to
3c41fdf
Compare
This section explains the problem with Django's `db.transaction.atomic`, and why django-subatomic offers a solution to avoid the problem, and two other alternatives considered.
3c41fdf to
b13d257
Compare
meshy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This section explains the problem with Django's
db.transaction.atomic, and why django-subatomic offers a solution to avoid the problem, and two other alternatives considered.Note: this is added to the main docs page for now, but we can re-arrange it as we go along.
Fixes #35
See following screenshot for rendered docs:
