Skip to content

Conversation

@mmxw
Copy link
Contributor

@mmxw mmxw commented Sep 23, 2025

This section explains the problem with Django's db.transaction.atomic, and why django-subatomic offers a solution to avoid the problem, and two other alternatives considered.

Note: this is added to the main docs page for now, but we can re-arrange it as we go along.

Fixes #35

See following screenshot for rendered docs:
Screenshot 2025-10-08 at 16 09 39

Screenshot 2025-10-08 at 16 15 25

@mmxw mmxw requested a review from a team as a code owner September 23, 2025 12:53
Copy link
Collaborator

@meshy meshy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I think some of the examples might have gone a little astray in translating from our internal docs, so will need some fixing.

@meshy
Copy link
Collaborator

meshy commented Sep 24, 2025

Thought: Because each example has slightly different code and tests, perhaps we could put them both side-by-side with https://squidfunk.github.io/mkdocs-material/reference/grids/#using-generic-grids

@mmxw mmxw force-pushed the add-after-commit-testing-explanation branch 2 times, most recently from da63446 to 0176606 Compare September 24, 2025 21:21
@mmxw
Copy link
Contributor Author

mmxw commented Sep 24, 2025

Thought: Because each example has slightly different code and tests, perhaps we could put them both side-by-side with https://squidfunk.github.io/mkdocs-material/reference/grids/#using-generic-grids

Grids seem promising - I tried to arrange it using grid but wasn't able to find a way to present the information in an intuitive way, so I re-arranged the code a bit (the screenshot in the description is also updated). Let me know what you think!

@mmxw mmxw force-pushed the add-after-commit-testing-explanation branch from 0176606 to 2cc064d Compare September 24, 2025 21:38
@mmxw mmxw requested a review from meshy September 24, 2025 21:39
@mmxw mmxw force-pushed the add-after-commit-testing-explanation branch from 2cc064d to ac6598b Compare September 24, 2025 21:42
@mmxw mmxw force-pushed the add-after-commit-testing-explanation branch 2 times, most recently from 7f5eedc to 87bf7ad Compare October 8, 2025 14:07
Copy link
Collaborator

@meshy meshy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things to consider before our pairing session:

@mmxw mmxw force-pushed the add-after-commit-testing-explanation branch 3 times, most recently from e11808b to 3ecff46 Compare October 8, 2025 15:09
@mmxw mmxw requested a review from meshy October 8, 2025 15:10
@mmxw mmxw force-pushed the add-after-commit-testing-explanation branch from 3ecff46 to 3c41fdf Compare October 8, 2025 15:15
mmxw added 2 commits October 8, 2025 16:27
This section explains the problem with Django's `db.transaction.atomic`,
and why django-subatomic offers a solution to avoid the problem, and two
other alternatives considered.
@mmxw mmxw force-pushed the add-after-commit-testing-explanation branch from 3c41fdf to b13d257 Compare October 8, 2025 15:27
Copy link
Collaborator

@meshy meshy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@meshy meshy merged commit 3115154 into main Oct 8, 2025
7 checks passed
@meshy meshy deleted the add-after-commit-testing-explanation branch October 8, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extract after-commit testing explanation from kraken's docs

3 participants