Skip to content

update new member instructions #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −7
Open

update new member instructions #835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions .github/ISSUE_TEMPLATE/join_org.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,10 @@ Please read the [guidelines](https://www.kubeflow.org/docs/about/contributing/#j

### Create a new membership pull request (PR):
- Fork the [kubeflow/internals-acls](https://github.com/kubeflow/internal-acls/) repo and clone it locally.
- Modify [github-orgs/kubeflow/org.yaml](github-orgs/kubeflow/org.yaml) to include your GitHub username in the appropriate places.
- In the `org.kubeflow.members` list
- If you work for a company that is recognized by the Kubeflow project, then in your company team list (check `org.kubeflow.teams`)
- Modify [github-orgs/kubeflow/org.yaml](github-orgs/kubeflow/org.yaml) to include your GitHub username in the `org.kubeflow.members` list.
Copy link
Member Author

@jonburdo jonburdo Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks to me like org.kubeflow.teams is no longer relevant for new members?

- Test your code changes with:
```bash
cd github_orgs
pytest test_org_yaml.py
pytest github-orgs/test_org_yaml.py
Comment on lines -23 to +21
Copy link
Member Author

@jonburdo jonburdo Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a minimum github_orgs should be github-orgs

Copy link
Member Author

@jonburdo jonburdo Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also could be more self contained with:

uv run --with pytest pytest github-orgs/test_org_yaml.py

or

pip install pytest && pytest github-orgs/test_org_yaml.py

Probably fine as is though

```
Confirm that the test run passed, and make sure to copy the test output so you can include it in your PR description (on GitHub).
- Push your changes to your `kubeflow/internals-acls` repository fork.
Expand All @@ -31,4 +28,4 @@ Please read the [guidelines](https://www.kubeflow.org/docs/about/contributing/#j
## Additional Instructions
- After your PR is merged please wait at least 1 hour for changes to propagate.
- You will receive an email invite (to your GitHub associated email address) to join Kubeflow on GitHub. Follow the instructions on the email to accept your invitation.
- If after an hour you haven't received an invite to join the GitHub org (or your invite has expired) please open an issue with an [owner](../../OWNERS) tagged to request follow-up.
- If after an hour you haven't received an invite to join the GitHub org (or your invite has expired) please open an issue with an [owner](https://github.com/kubeflow/internal-acls/blob/master/OWNERS) tagged to request follow-up.
Copy link
Member Author

@jonburdo jonburdo Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These relative paths work when you view the template file in the repo, but not when you actually create an issue

5 changes: 4 additions & 1 deletion github-orgs/test_org_yaml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,15 @@
- All team maintainers and members appear under org admins or members
"""

import os.path as osp

import yaml

ORG_YAML = "kubeflow/org.yaml"

def test_team_member_is_in_org():
with open(ORG_YAML) as stream:
path = osp.join(osp.dirname(__file__), ORG_YAML)
with open(path) as stream:
org_data = yaml.safe_load(stream)
Comment on lines +8 to 17
Copy link
Member Author

@jonburdo jonburdo Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make path relative to this script rather than relative to the current working directory. This enables running from a different directory such as the repo's root dir: pytest github-orgs/test_org_yaml.py


for org_name, org in org_data["orgs"].items():
Expand Down