feat: serve workspacekind assets (logos + icons) #736
+1,283
−213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-oss-prow
bot
added
do-not-merge/work-in-progress
area/backend
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
added
area/controller
andyatmiami
force-pushed
the
feat/logos-icons
branch
3 times, most recently
from
37c0693 to
45316eb
Compare
andyatmiami
force-pushed
the
feat/logos-icons
branch
3 times, most recently
from
9b203ac to
8e051f4
Compare
Contributor
Author
|
/ok-to-test |
This commit implements serving of workspacekind assets (logos and icons)
from ConfigMaps through the backend API, with SHA256 hash support for
cache-busting.
Key changes:
- Add endpoint to serve workspacekind assets from ConfigMaps at
`/api/v1/workspacekinds/{name}/assets/{icon|logo}.svg`
- Compute and include SHA256 hashes for ConfigMap-based assets as query
parameters for cache-busting
- Add ConfigMap client support to repositories for accessing asset content
- partial cache for performance/efficiency that keys off label:
- `notebooks.kubeflow.org/image-source: true`
- Add GetConfigMapContent method to WorkspaceKindRepository for
retrieving asset content from ConfigMaps
- Update model functions to support SHA256 hashes in asset URLs:
- NewWorkspaceKindModelFromWorkspaceKindWithAssetHashes
- NewWorkspaceModelFromWorkspaceWithAssetHashes
- Added workspacekind_imagesource_configmap.yaml for reference example
- Refactored `backend` `mgr` setup in `main.go` to leverage `helper/k8s.go`
- easier to keep logic in sync in e2e tests - particularly with new partial cache
Remote URL specification of assets is still supported - but the browser queries
the source URL directly for content.
Signed-off-by: Andy Stoneberg <[email protected]>
andyatmiami
force-pushed
the
feat/logos-icons
branch
from
8e051f4 to
ec35a7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #692
This commit implements serving of workspacekind assets (logos and icons) from ConfigMaps through the backend API, with SHA256 hash support for cache-busting.
Key changes:
/api/v1/workspacekinds/{name}/assets/{icon|logo}.svgnotebooks.kubeflow.org/image-source: trueWorkspaceKindRepositoryandWorkspaceRepositoryfor retrieving asset content from ConfigMapsbackendmgrsetup inmain.goto leveragehelper/k8s.goRemote URL specification of assets is still supported - but the browser queries
the source URL directly for content.
SCREENSHOTS