ci: Upgrade Python to 3.12 and NodeJS to 24 for all imaged under example-notebook-servers #756
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
added
the
area/server-images
| # install - tensorflow | ||
| # - About '[and-cuda]' option: https://github.com/tensorflow/tensorflow/blob/v2.17.1/tensorflow/tools/pip_package/setup.py#L153-L164 | ||
| # - TODO: when updating TensorRT, you might need to change `tensorrt`, `tensorrt-libs`, and `tensorrt-bindings` | ||
| # to `tensorrt-cu12`, `tensorrt-cu12-libs`, and `tensorrt-cu12-bindings` respectively |
There was a problem hiding this comment.
This TODO comment was actually completed in this PR - you've successfully migrated from tensorrt to tensorrt-cu12 packages. Consider removing this TODO or marking it as resolved:
| # - https://github.com/tensorflow/tensorflow/issues/61986#issuecomment-1880489731 | ||
| # - We are creating symlinks for the following libs, as this is where TF looks for them: | ||
| # - libnvinfer.so.8.6.1 -> libnvinfer.so.8 | ||
| # - libnvinfer_plugin.so.8.6.1 -> libnvinfer_plugin.so.8 |
There was a problem hiding this comment.
The comments here still reference the old TensorRT version 8.6.1, but should be updated to reflect the new version 10.2.0:
Current comments mention libnvinfer.so.8.6.1 -> libnvinfer.so.8
Should be: libnvinfer.so.10.2.0 -> libnvinfer.so.10
liavweiss
changed the title
Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]>
liavweiss
force-pushed
the
feature/python-3.12-example-notebook-server
branch
from
b2bd67f to
8c58130
Compare
|
/lgtm |
|
/hold I want to first review this approach with @thesuperzapper before continuing down this path. with a potential looming From experience - server images like this are generally a bit of a "house of cards" - so before we invest time in reviewing and testing these images - I wanna make sure we have all changes included. Additionally - I (greatly) appreciate the evidence you have provided on testing these images - but again wanna sync with @thesuperzapper to understand historically how we have verified these types of sweeping changes:
|
3 participants
closes: #727 #732
Title
Upgrade Python to 3.12 and Node to 24 across
example-notebook-servers(Gaudi images excluded for now).Summary
example-notebook-serversimages.jupyterimages.Validation:
example_notebook_servers_publish.yamlpassed successfully and built all images.jupyterjupyter-tensorflow-cudacode-server-pythonrsudio