✨ Improve logs, errors and conditions #12992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/L
sbueringer
force-pushed
the
pr-improv-logs-conditions-errors
branch
2 times, most recently
from
32646a7 to
3d8471e
Compare
Member
Author
|
/test pull-cluster-api-e2e-main-gke |
sbueringer
force-pushed
the
pr-improv-logs-conditions-errors
branch
6 times, most recently
from
ec19e5a to
7808ca8
Compare
sbueringer
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Member
Author
|
/test pull-cluster-api-e2e-main-gke |
Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-improv-logs-conditions-errors
branch
from
7808ca8 to
13fe2dc
Compare
Member
Author
|
/test pull-cluster-api-e2e-main-gke |
Member
|
Great to see logs consistency improve across controllers! |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
LGTM label has been added. Git tree hash: 0967728beafdab7d8b56986944605f34802ef81b
|
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Did some extensive testing with Fabrizio in the context of in-place updates.
This PR improves logs, errors and conditions across the code base.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #