Skip to content

✨ Introduce reconciler rate-limiting and hook caching #13006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2025
Merged

✨ Introduce reconciler rate-limiting and hook caching #13006

merged 1 commit into from
Nov 20, 2025

Conversation

@sbueringer
Copy link
Member

@sbueringer sbueringer commented Nov 18, 2025

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #13005
Related #12975
Related #12720

@sbueringer sbueringer changed the title ✨ Introduce reconciler rate-limiting and hook caching [WIP] ✨ Introduce reconciler rate-limiting and hook caching Nov 18, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Nov 18, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 18, 2025
@sbueringer sbueringer added the area/misc Issues or PRs not related to any other area label Nov 18, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Nov 18, 2025
@sbueringer
Copy link
Member Author

sbueringer commented Nov 18, 2025

/test pull-cluster-api-e2e-main-gke

@sbueringer sbueringer force-pushed the pr-kcp-in-place branch 3 times, most recently from 03cbc3e to 74efdc0 Compare November 18, 2025 09:28
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 18, 2025
@sbueringer sbueringer force-pushed the pr-kcp-in-place branch 15 times, most recently from e3a2605 to 277a694 Compare November 19, 2025 06:01
@sbueringer sbueringer force-pushed the pr-kcp-in-place branch 3 times, most recently from cecdebf to 370b23c Compare November 19, 2025 08:31
sbueringer
sbueringer commented Nov 19, 2025
View reviewed changes
Makefile

# Required with Go 1.24 to enable usage of synctest in unit tests
# Can be removed after we bumped to Go 1.25.
export GOEXPERIMENT=synctest
Copy link
Member Author

@sbueringer sbueringer Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracked on #12700

@sbueringer sbueringer force-pushed the pr-kcp-in-place branch 2 times, most recently from 46c432a to 9f00921 Compare November 19, 2025 09:04
@sbueringer sbueringer changed the title [WIP] ✨ Introduce reconciler rate-limiting and hook caching ✨ Introduce reconciler rate-limiting and hook caching Nov 19, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2025
@sbueringer
Copy link
Member Author

sbueringer commented Nov 19, 2025

/test pull-cluster-api-e2e-main-gke

@sbueringer
Copy link
Member Author

sbueringer commented Nov 19, 2025

/test pull-cluster-api-e2e-main-gke

fabriziopandini
fabriziopandini reviewed Nov 19, 2025
View reviewed changes
fabriziopandini
fabriziopandini reviewed Nov 20, 2025
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@sbueringer
Copy link
Member Author

sbueringer commented Nov 20, 2025

/test pull-cluster-api-e2e-main-gke

@fabriziopandini
Copy link
Member

fabriziopandini commented Nov 20, 2025

Nice
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 20, 2025

LGTM label has been added.

Git tree hash: 5dce0c3e494f9d39dec4ccfd4f1728d3755d8d5d

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 20, 2025 •
edited
Loading

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main b81eae5 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sbueringer
Copy link
Member Author

sbueringer commented Nov 20, 2025

/override pull-cluster-api-e2e-main-gke

Independent flake, see #13008

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 20, 2025

@sbueringer: Overrode contexts on behalf of sbueringer: pull-cluster-api-e2e-main-gke

In response to this:

/override pull-cluster-api-e2e-main-gke

Independent flake, see #13008

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 9e3c820 into kubernetes-sigs:main Nov 20, 2025
19 of 20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Nov 20, 2025
@sbueringer sbueringer deleted the pr-kcp-in-place branch November 20, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@elmiko elmiko Awaiting requested review from elmiko

Assignees

@fabriziopandini fabriziopandini

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/misc Issues or PRs not related to any other area cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

v1.12

Development

Successfully merging this pull request may close these issues.

3 participants

@sbueringer @fabriziopandini @k8s-ci-robot