-
Notifications
You must be signed in to change notification settings - Fork 1.4k
🌱 Defer in-place updates for machines not yet provisioned #13007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Defer in-place updates for machines not yet provisioned #13007
Conversation
|
/test |
|
@fabriziopandini: The The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-cluster-api-e2e-main-gke |
|
Thank you ! /lgtm |
|
LGTM label has been added. Git tree hash: ca9b3ea5d36e5f2edfda660e650f33ed4907b3a5
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR introduces a safeguard that temporarily defers starting an in-place upgrade for machine set machines not yet fully provisioned.
Please note that a similar safeguard is not required in KCP, because it already gates in-place updates with preflight checks ensure all the node involved are healthy (and thus fully provisioned). Nevertheless, I also implemented an additional safeguard in the Machine controller
Part of #12291
/area machinedeployment