Skip to content

🌱 e2e: use wait-machine-upgrade timeout in ClusterClassChanges tests to wait for machines to be ready #13013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2025
Merged

🌱 e2e: use wait-machine-upgrade timeout in ClusterClassChanges tests to wait for machines to be ready #13013

merged 1 commit into from
Nov 20, 2025
+43 −6

Conversation

@chrischdi
Copy link
Member

@chrischdi chrischdi commented Nov 20, 2025 •
edited
Loading

What this PR does / why we need it:

While developing: kubernetes-sigs/cluster-api-provider-aws#5720

We hit the issue of the timeout to verify if machines are ready

This makes the timeout configurable via wait-machine-ready

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area e2e-testing

@k8s-ci-robot k8s-ci-robot added area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 20, 2025
This was referenced Nov 20, 2025
Merged
Closed
damdo
damdo reviewed Nov 20, 2025
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @chrischdi !

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 20, 2025

LGTM label has been added.

Git tree hash: d18bfcc5364342e47674669164d88869c23fdcd1

@chrischdi
Copy link
Member Author

chrischdi commented Nov 20, 2025

/hold

For a green ClusterClass changes test here: kubernetes-sigs/cluster-api-provider-aws#5756

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2025
@chrischdi chrischdi force-pushed the pr-verify-machines-ready-timeout branch from 5f560f8 to e285b1d Compare November 20, 2025 12:17
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2025
@k8s-ci-robot k8s-ci-robot requested a review from damdo November 20, 2025 12:17
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 20, 2025
@chrischdi chrischdi force-pushed the pr-verify-machines-ready-timeout branch from e285b1d to 1aef68a Compare November 20, 2025 12:18
@chrischdi chrischdi changed the title 🌱 e2e: make timeout for VerifyMachinesReady configurable 🌱 e2e: use wait-machine-upgrade timeout in ClusterClassChanges tests to wait for machines to be ready Nov 20, 2025
@chrischdi
Copy link
Member Author

chrischdi commented Nov 20, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2025
damdo
damdo reviewed Nov 20, 2025
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 20, 2025

LGTM label has been added.

Git tree hash: 743a9dd3dd750ee17e79bae4660b60789bf8b764

@sbueringer
Copy link
Member

sbueringer commented Nov 20, 2025

/test pull-cluster-api-e2e-main-gke
/lgtm
/approve

Thx!

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2025
@chrischdi
Copy link
Member Author

chrischdi commented Nov 20, 2025

/cherry-pick release-1.11

@k8s-infra-cherrypick-robot
Copy link

k8s-infra-cherrypick-robot commented Nov 20, 2025

@chrischdi: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbueringer
Copy link
Member

sbueringer commented Nov 20, 2025

/retest

@k8s-ci-robot k8s-ci-robot merged commit a663a54 into kubernetes-sigs:main Nov 20, 2025
24 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Nov 20, 2025
@k8s-infra-cherrypick-robot
Copy link

k8s-infra-cherrypick-robot commented Nov 20, 2025

@chrischdi: new pull request created: #13022

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Nov 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elmiko elmiko Awaiting requested review from elmiko

@sivchari sivchari Awaiting requested review from sivchari

1 more reviewer

@damdo damdo damdo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sbueringer sbueringer

@damdo damdo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.12

Development

Successfully merging this pull request may close these issues.

5 participants

@chrischdi @k8s-ci-robot @sbueringer @k8s-infra-cherrypick-robot @damdo